Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
"Open Line Changes with..." doesn't work for renamed files #552
Yep, still happening in 9 beta. Here's what happens when I run the two comparison commands (new wording seems less intuitive than "Compare Commit with..." but maybe that's just me):
Open Line Changes with Previous Revision:
Open Line Changes with Working File:
You don't have that issue when you follow those steps?
@philraj what exactly are the steps you are following?
Hrm, I've constantly struggled with the naming of that command. I want to make it clear that it is line specific, rather than file specific -- e.g. just walking back to the previous commit of the file. And rather than calling it Compare Line Commit with..., I've aligned with vscode's terminology for diff comparisons -- as they use Open Changes
Oh, you want to emphasize that the commit you're comparing with is the one from that specific line. I think "Compare Commit with..." was the most ergonomic one so far (I think I saw a few of the previous ones) but you're right, it's tricky to find the right wording that's clear but not too verbose. ("Open Changes Between This Line's Commit And The Revision Before It" doesn't really roll off the tongue)
The steps I'm following are the same I listed in the original bug report, but just to make sure you can follow exactly in my footsteps:
Your git log should show 3 commits: 2 which change the file contents, and one which is a rename.