Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #617: Adds version links to CHANGELOG #660

Merged
merged 2 commits into from Mar 17, 2019

Conversation

Projects
None yet
2 participants
@shadowspawn
Copy link
Contributor

commented Feb 20, 2019

Description

Add reference links in CHANGELOG for releases so version number link shows changesets in the release, where tags available . Remove the square brackets around versions where tags not available.

Related issue is #617

Checklist

No code changes.

  • I have followed the guidelines in the Contributing document
  • My changes are based off of the develop branch
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

shadowspawn and others added some commits Feb 20, 2019

Closes #617: Adds version links to CHANGELOG
- add version links to show changesets at bottom of document for releases that have both tags
- remove square brackets for versions that are missing tags

@eamodio eamodio merged commit 0428d59 into eamodio:develop Mar 17, 2019

@eamodio

This comment has been minimized.

Copy link
Owner

commented Mar 17, 2019

@shadowspawn Thank you! And sorry for the delay.

@shadowspawn

This comment has been minimized.

Copy link
Contributor Author

commented Mar 17, 2019

No worries on delay. Happy to contribute.

@shadowspawn shadowspawn deleted the shadowspawn:develop branch Mar 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.