Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses GitHub Avatar for GH 'noreply' email address #814

Merged
merged 1 commit into from Aug 20, 2019

Conversation

@bolte-17
Copy link
Contributor

commented Aug 6, 2019

Description

Partial fix for #281 - covers the *@users.noreply.github.com case.

The users.noreply.github.com domain comes from users
making use GitHub's 'email privacy' feature.
Since the noreply address doesn't accept email, a user can't link
their preferred Gravatar to this type of email address.

The upside is that this address is easily parseable into:

  • (optional) Github User ID
  • Github User Name

We can use either to create the associated avatar link
without actually having to do an additional request
against Github's user search API.

Example changes from "contributors" list of this repository:
Before
->
After

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes are based off of the develop branch
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses
Partial fix for #281- covers the `*@users.noreply.github.com` case.

The `users.noreply.github.com` domain comes from users
making use GitHub's 'email privacy' feature.
Since the noreply address doesn't accept email, a user can't link
their preferred Gravatar to this type of email address.

The upside is that this address is easily parsable into:
* (optional) Github User ID
* Github User Name

We can use either to create the associated avatar link
without actually having to do an additonal request
against Github's user search API.
@eamodio eamodio merged commit 1657829 into eamodio:develop Aug 20, 2019
@eamodio

This comment has been minimized.

Copy link
Owner

commented Aug 20, 2019

Thank you so much for your contribution!

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.