Uses GitHub Avatar for GH 'noreply' email address #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partial fix for #281- covers the `*@users.noreply.github.com` case. The `users.noreply.github.com` domain comes from users making use GitHub's 'email privacy' feature. Since the noreply address doesn't accept email, a user can't link their preferred Gravatar to this type of email address. The upside is that this address is easily parsable into: * (optional) Github User ID * Github User Name We can use either to create the associated avatar link without actually having to do an additonal request against Github's user search API.
|
Thank you so much for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partial fix for #281 - covers the
*@users.noreply.github.comcase.The
users.noreply.github.comdomain comes from usersmaking use GitHub's 'email privacy' feature.
Since the noreply address doesn't accept email, a user can't link
their preferred Gravatar to this type of email address.
The upside is that this address is easily parseable into:
We can use either to create the associated avatar link
without actually having to do an additional request
against Github's user search API.
Example changes from "contributors" list of this repository:
->
Checklist
developbranchFixes $XXX -orCloses #XXX -prefix to auto-close the issue that your PR addresses