Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't restore the original rules #1

Closed
NKjoep opened this issue Feb 21, 2017 · 3 comments
Closed

Doesn't restore the original rules #1

NKjoep opened this issue Feb 21, 2017 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@NKjoep
Copy link

NKjoep commented Feb 21, 2017

For instance, with this files.exclude settings:

{
  "files.exclude": {
     "**/*.js": {"when": "$(basename).ts"}
  }
}

Then using your toggler it restores the config overriding the original rule config with true|false, like this:

{
  "files.exclude": {
     "**/*.js": true
  }
}

Do you think is it possible to improve this? :)

@eamodio eamodio self-assigned this Feb 21, 2017
@eamodio eamodio added the bug Something isn't working label Feb 21, 2017
@eamodio
Copy link
Owner

eamodio commented Feb 21, 2017

@NKjoep Thanks for the report -- I will definitely look into fixing this. (Honestly I didn't even know you could do that in an exclude!) :)

@NKjoep
Copy link
Author

NKjoep commented Feb 21, 2017

Yep it is possible and it is super handy!

If you read this doc they explain how to use the patterns.

AFAIK, supported keywords are $(basename) and $(filename), there's also an open issue about that microsoft/vscode#4642

@github-actions
Copy link

github-actions bot commented Mar 6, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants