Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gemini.util.RADecMath.string2Degrees would accept FK4 as FK5 #1

Open
grahambell opened this issue Dec 6, 2013 · 1 comment
Open

Comments

@grahambell
Copy link
Contributor

The code says:

// For now, assume everything is FK5/J2000
// Or FK4 - added by AB for ORAC 13-Oct-99
Assert.notFalse( ( coordSystem == CoordSys.FK5 ) || ( coordSystem == CoordSys.FK4 ) ) ;

But it does nothing else with coordSystem so coordinates supplied in FK4 will presumably be wrong.

@timj
Copy link
Contributor

timj commented Dec 6, 2013

Right. The OT was never designed for Galactic coordinates. For most of the life of the OT it Galactic was specifically in the position editor for convenience but all other offsets were assumed to be J2000.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants