Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] HTTPS support #628

Open
rebane2001 opened this issue May 18, 2023 · 1 comment
Open

[Feature request] HTTPS support #628

rebane2001 opened this issue May 18, 2023 · 1 comment

Comments

@rebane2001
Copy link

At the moment this library can only play content from insecure HTTP sources, but it'd be awesome to see it play HTTPS as well since HTTPS-only sources are becoming more and more common.

I got HTTPS to work for myself by using WiFiClientSecure in AudioFileSourceHTTPStream.h and setting the right root ca (or you can do client.setInsecure()) in AudioFileSourceHTTPStream.cpp. I imagine this isn't the best way to go about things, hence the issue and not a PR, but it works great for me.

Perhaps it could also make sense to instead let the user provide their own WiFiClient along the lines of file = new AudioFileSourceHTTPStream(URL, client); so that the user can use their own WiFiClientSecure and root ca instead of delegating this to the audio library.

@positron96
Copy link

Huh, so that's why I couldn't play https streams...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants