Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is docker required in the chords_app image #585

Open
MisterMartin opened this issue Feb 10, 2023 · 3 comments
Open

Is docker required in the chords_app image #585

MisterMartin opened this issue Feb 10, 2023 · 3 comments
Labels
bug reported bug
Projects

Comments

@MisterMartin
Copy link
Member

The Dockerfile (RUN curl -sSL https://get.docker.com/) installs docker within the chords_app image. This was required for some sort of inter-container coordination back in the day, but is it required anymore?

@MisterMartin MisterMartin added the bug reported bug label Feb 10, 2023
@MisterMartin MisterMartin added this to To do in Release 1.1 via automation Feb 10, 2023
@MisterMartin
Copy link
Member Author

It looks like it is used for the config page database export/import function (profiles_controller.rb: export_influxdb and import_influxdb. I think this may be available via http; but perhaps we should just leave it as is for now.

@mdye mdye moved this from To do to In progress in Release 1.1 Mar 4, 2023
@mdye
Copy link
Collaborator

mdye commented Mar 4, 2023

There are a couple of other places that do a "docker exec" from within the (Rails) code:

app/controllers/profiles_controller.rb: This is the bulk export capability. When I developed this I looked in to the http option, but funneling all the data over http between containers was a huge performance hit and consumed a lot more memory.

bin/certbot/renew_hooks.sh : reloading the nginx container

I thikn this should be left in place, as much as I'd like to decrease the size of the container.

@MisterMartin
Copy link
Member Author

Need to remind me how the bulk influxdb import/export works. It would require a parallel dump/restore of mysql, right? What was the use case for this?

We now have the chords_control backup/restore functions, for complete portal backups. Does this duplicate the browser export?

Also, what is the reference to “bin/certbot/renew_hooks.sh : reloading the nginx container” about? I think that has to do with renewing ssl certs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug reported bug
Projects
Release 1.1
  
In progress
Development

No branches or pull requests

2 participants