Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default editor for nbdistribute #39

Closed
betatim opened this issue Dec 16, 2018 · 1 comment
Closed

Default editor for nbdistribute #39

betatim opened this issue Dec 16, 2018 · 1 comment

Comments

@betatim
Copy link
Collaborator

betatim commented Dec 16, 2018

When asking the user for a commit message we check the EDITOR and VISUAL environment variables to try and figure out what (command-line?) editor the user prefers. If we can't find anything vi is used. There is no particularly good reason to use vi as fallback.

There are two things to do:

  • are there more variables or places we can check to find out what editor the user would like us to use?
  • decide what the default editor should be
@lwasser
Copy link

lwasser commented Dec 17, 2018

oh gosh that would be great. i was good for me as it forced me to learn vim this weekend. But i have atom set as my default editor. we can't assume all users will have atom installed but it would be nice if it would find our default editor rather than defaulting to vim!

@lwasser lwasser closed this as completed Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants