Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branches build up in student directories #47

Closed
lwasser opened this issue Dec 18, 2018 · 1 comment
Closed

Branches build up in student directories #47

lwasser opened this issue Dec 18, 2018 · 1 comment

Comments

@lwasser
Copy link

lwasser commented Dec 18, 2018

Currently each time i merge a PR, the branches in that repo build up (please see image below). I think we need to clean up the branch created each time by the PR. otherwise it could get difficult to manage. i am not sure what the best approach to this would be. One option could be to clean up the previous branch each time a new pr is created? so then there is always just one branch that is there unless the student deletes it when they merge the PR. Or could the PR come from the template repo rather than from a branch within the student's repo? that would be the cleanest option. i'm just unclear as to what is happening with this PR process.
screen shot 2018-12-18 at 4 10 35 pm

@lwasser lwasser changed the title Branches in student directories Branches build up in student directories Dec 18, 2018
@betatim
Copy link
Collaborator

betatim commented Dec 19, 2018

I think we could delete old branches when we make a new PR. Important to check if a branch has been merged (or the corresponding PR closed) before deleting them.

My feeling was that using the template repository as the source of the PR would be trickier. The thinking was:

  • we still need a way to clean up
  • we need to generate a diff/PR that brings that student's repo up to date. It wouldn't be the same for all students (for example if you didn't merge last weeks PR you need a different one this week compared to someone who did merge it)
  • we need to add lots of remotes to the template repo (one for each student)

So I'd investigate automatically cleaning up old/stale/unused branches when we create a new one.

@lwasser lwasser closed this as completed Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants