Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack() doesn't mask array when a file path is provided #493

Closed
lwasser opened this issue Feb 19, 2020 · 3 comments
Closed

Stack() doesn't mask array when a file path is provided #493

lwasser opened this issue Feb 19, 2020 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@lwasser
Copy link

lwasser commented Feb 19, 2020

Describe the bug
This is really weird. in the week 6 demo notebook, when you provide an output path for stack it does NOT return a masked array. But when you do provide a path it DOES return a masked array. This is not the expected behavior.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

**What Operating System Are you Running? **

  • Mac
  • Windows
  • Linux

Additional context
Add any other context about the problem here.

@nkorinek
Copy link
Member

nkorinek commented Apr 1, 2020

This issue was confusing me, so I made a gist to describe why I am confused, here: https://gist.github.com/nkorinek/655d590da99b5f26dca8b02208599aea. @lwasser let me know if the gist makes sense? I'll put in the fix suggested if you give the go ahead

@lwasser
Copy link
Author

lwasser commented Apr 2, 2020

please go ahead and implement this fix!

@lwasser lwasser added the bug Something isn't working label Apr 2, 2020
@lwasser
Copy link
Author

lwasser commented Jun 18, 2020

closing this as it was addressed in #525

@lwasser lwasser closed this as completed Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants