Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User friendly parameter defintion #21

Closed
meteoDaniel opened this issue Sep 15, 2019 · 2 comments · Fixed by #48
Closed

User friendly parameter defintion #21

meteoDaniel opened this issue Sep 15, 2019 · 2 comments · Fixed by #48
Labels
enhancement New feature or request

Comments

@meteoDaniel
Copy link
Contributor

meteoDaniel commented Sep 15, 2019

I think it is not very comfortable to source all enumerations everytime.
I think we can build up wrapper with a bit fuzzy logic to determine the Parameter, periodType and TimeResolution.
This is quite similar to issue #8

define_request(parameter='precipitation', time_resolution='10min', start_date?, end_date?,) 

Enumerations are helpful to make the code clean but they are not very user friendly I think.

@meteoDaniel meteoDaniel added the enhancement New feature or request label Sep 15, 2019
@gutzbenj
Copy link
Member

My original thought with parsing parameters from the file was that you could start anywhere between checking metadata and parsing data into a dataframe. But probably you are right, that nobody would use only one function but it's more like a tube that would mean that only a combination of all those functions make it work. This way instead of a function I would suggest a class. Either this class will call our functions one after each other, or our functions will "complete" our class by time, and if certain steps are not done, for example a link to the file is not given, it will throw an error when trying to download the file.

What do you think?

@meteoDaniel
Copy link
Contributor Author

meteoDaniel commented Oct 28, 2019

This is a good point. Maybe we provide once a script that is managing the whole pipeline. There we need a defined interface. and if anyone would like to use one of the functions in the pipeline they have to check the usage by themself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants