Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider switching from base58 to base32 to improve URL compatability #29

Closed
cinnamon-bun opened this issue Jul 16, 2020 · 2 comments
Closed
Labels
enhancement New feature or request

Comments

@cinnamon-bun
Copy link
Member

cinnamon-bun commented Jul 16, 2020

Problem

Workspace names need to be case sensitive to preserve their base58 secrets.

URL locations are supposed to be NOT case sensitive, and some URL parsers will lowercase them for you.

This matters if we want to make our own URL scheme like earthstar:// without fighting the URL parser.

Solution?

Switch workspace and author addresses to lowercase base32 encoding.

Secrets will be 52 chars long instead of 44. This isn't significantly worse.

See this comment for details.

@cinnamon-bun cinnamon-bun added the enhancement New feature or request label Jul 16, 2020
@cinnamon-bun cinnamon-bun added this to the v1 milestone Jul 16, 2020
@cinnamon-bun
Copy link
Member Author

Done!

@christianbundy
Copy link
Contributor

Congrats on the change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants