Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CORS access-control-allow-origin to allow connections from other web apps like "letterbox" #1

Closed
johanbove opened this issue Apr 22, 2022 · 3 comments

Comments

@johanbove
Copy link

johanbove commented Apr 22, 2022

When connecting a replica-server-glitch to an instance of "letterbox", for instance on https://tools.earthstar-project.org/, the browser will refuse to connect to the remote Glitch server as it is missing the "“Access-Control-Allow-Origin" header with value "*" to allow incoming connections from any other domain.

Could it be made an option in the Glitch project to set the allowed domains?

@sgwilym
Copy link
Contributor

sgwilym commented Apr 23, 2022

Oh duh, that's what I get for only testing with the CLI. I think this should probably be the default rather than an option.

@sgwilym
Copy link
Contributor

sgwilym commented Apr 23, 2022

Added to the replica-server lib, and have updated this repo and the Glitch project. Thanks for catching this!

@sgwilym sgwilym closed this as completed Apr 23, 2022
@johanbove
Copy link
Author

You're welcome :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants