Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linux aarch64 wheel build support #276

Merged
merged 1 commit into from Aug 10, 2021

Conversation

odidev
Copy link
Contributor

@odidev odidev commented Aug 6, 2021

Add linux aarch64 wheel build support.

Related to #275 @earwig Could you please review this PR?

Signed-off-by: odidev <odidev@puresoftware.com>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.168% when pulling e1df071 on odidev:odidev_mwparserfromhell into dcf7ba4 on earwig:develop.

@legoktm
Copy link
Contributor

legoktm commented Aug 8, 2021

Very cool! Did you test the wheels generated by this on an aarch64 platform to make sure they work?

The use of QEMU rather than cross compiling or using a proper aarch64 runner is interesting, but it seems like that's what pypa does too: https://cibuildwheel.readthedocs.io/en/stable/faq/#emulation

@odidev
Copy link
Contributor Author

odidev commented Aug 10, 2021

Very cool! Did you test the wheels generated by this on an aarch64 platform to make sure they work?

Yes, I have tested the generated wheels and they are working fine.

The use of QEMU rather than cross-compiling or using a proper aarch64 runner is interesting, but it seems like that's what pypa does too: https://cibuildwheel.readthedocs.io/en/stable/faq/#emulation

Yes, the pypa also uses qemu with cibuildwheel as arm64 is not directly supported in github actions and currently there is no tool for cross-compilation.

@earwig
Copy link
Owner

earwig commented Aug 10, 2021

Thanks!

@earwig earwig merged commit 3a9d63f into earwig:develop Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants