Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve coverage #158

Closed
phanirithvij opened this issue Aug 1, 2021 · 2 comments · Fixed by #156 or #170
Closed

Improve coverage #158

phanirithvij opened this issue Aug 1, 2021 · 2 comments · Fixed by #156 or #170
Assignees
@localvar @benja-wu @suchen-sci
Labels
enhancement New feature or request
Projects
Easegress Project
Milestone
v1.3.0

Comments

@phanirithvij
Copy link

The code coverage https://app.codecov.io/gh/megaease/easegress seems to be less than 60%.

It would be great if it can be brought up around 80-90% and ideally a 100%.
@benja-wu benja-wu added the enhancement New feature or request label Aug 2, 2021
@benja-wu benja-wu added this to To do in Easegress Project via automation Aug 2, 2021
@benja-wu benja-wu moved this from To do to In progress in Easegress Project Aug 2, 2021
@benja-wu benja-wu added this to the v1.3.0 milestone Aug 2, 2021
@benja-wu
Copy link
Contributor

benja-wu commented Aug 2, 2021 •
edited

Hi, @phanirithvij. Thanks for the suggestion.
Yes, I am totally agreed with you. And We are working on raising the coverage rate aiming at 85% at least.

@benja-wu benja-wu linked a pull request Aug 5, 2021 that will close this issue
add unit tests #156
Merged
Easegress Project automation moved this from In progress to Done Aug 5, 2021
@benja-wu benja-wu reopened this Aug 5, 2021
Easegress Project automation moved this from Done to In progress Aug 5, 2021
@benja-wu benja-wu linked a pull request Aug 5, 2021 that will close this issue
add unit tests #170
Merged
Easegress Project automation moved this from In progress to Done Aug 6, 2021
@benja-wu
Copy link
Contributor

benja-wu commented Aug 6, 2021 •
edited

Hi， @phanirithvij
we,@localvar @suchen-sci , had added some test cases, and now the coverage rate is 81%.
https://app.codecov.io/gh/megaease/easegress
I closed this issue but we will continue to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@localvar localvar

@benja-wu benja-wu

@suchen-sci suchen-sci

Labels
enhancement New feature or request
Projects
Easegress Project
Done
Milestone
v1.3.0
Development

Successfully merging a pull request may close this issue.

add unit tests localvar/easegress
add unit tests localvar/easegress
4 participants
@localvar @benja-wu @phanirithvij @suchen-sci