Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extractText broken #2

Closed
patroza opened this issue Jul 15, 2016 · 7 comments
Closed

extractText broken #2

patroza opened this issue Jul 15, 2016 · 7 comments

Comments

@patroza
Copy link

patroza commented Jul 15, 2016

@easy-webpack\config-css\src\index.ts:31
        extractText = extractTextInstances.get(filename)
                                           ^
TypeError: extractTextInstances.get is not a function

The problem seems to be that the extractTextInstances in the metadata at some point gets JSON serialized and deserialized (perhaps by another part of the easy-webpack pipeline?), and thus it is no longer a Map, but an Object, and thus .get is not a function.

@niieani
Copy link
Contributor

niieani commented Jul 15, 2016

This was recently fixed in easy-webpack/assign. Please run npm update.

@niieani niieani closed this as completed Jul 15, 2016
@patroza
Copy link
Author

patroza commented Jul 15, 2016

interesting, however npm update doesnt update easy-webpack/assign .. investigating..

Update: It started updating when running

npm i @easy-webpack/assign
npm -v
3.10.3

@niieani
Copy link
Contributor

niieani commented Jul 15, 2016

easy-webpack/assign is a dependency of easy-webpack/core, try npm install @easy-webpack/core --save-dev.

@niieani
Copy link
Contributor

niieani commented Jul 15, 2016

Fixed in easy-webpack/assign@a6fb46a which is released as v0.9.12.

@patroza
Copy link
Author

patroza commented Jul 15, 2016

Then getting

node_modules\webpack\lib\Compilation.js:457
                rebuilding.forEach(function(cb) {
             ^
TypeError: Cannot read property 'node_modules\@easy-webpack\config-css\node_modules\extract-text-webpack-plugin' of null
    at node_modules\@easy-webpack\config-css\node_modules\extract-text-webpack-plugin\index.js:230:27
    at node_modules\webpack\lib\Compilation.js:458:4
    at Array.forEach (native)
    at callback (node_modules\webpack\lib\Compilation.js:457:14)
    at Compilation.<anonymous> (node_modules\webpack\lib\Compilation.js:478:4)
    at node_modules\webpack\lib\Compilation.js:325:10
    at node_modules\webpack\node_modules\async\lib\async.js:52:16
    at Object.async.forEachOf.async.eachOf (node_modules\webpack\node_modules\async\lib\async.js:236:30)
    at Object.async.forEach.async.each (node_modules\webpack\node_modules\async\lib\async.js:209:22)
    at Compilation.addModuleDependencies (node_modules\webpack\lib\Compilation.js:194:8)
    at Compilation.processModuleDependencies (node_modules\webpack\lib\Compilation.js:179:7)

@niieani
Copy link
Contributor

niieani commented Jul 15, 2016

Trying to reproduce on a freshly pulled skeleton-nav.

@niieani
Copy link
Contributor

niieani commented Jul 15, 2016

I'm unable to reproduce on a fresh skeleton. Try removing node_modules and run npm install; should fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants