Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid inventory over-rollback #221

Closed
gdlcf88 opened this issue Aug 19, 2022 · 0 comments · Fixed by #222
Closed

Avoid inventory over-rollback #221

gdlcf88 opened this issue Aug 19, 2022 · 0 comments · Fixed by #222
Assignees
Labels

Comments

@gdlcf88
Copy link
Member

gdlcf88 commented Aug 19, 2022

We should forbid users from canceling orders during the inventory reduction state.

Currently, we can cancel orders during the inventory reduction state. After the order is canceled, the InventoryRollbackOrderCanceledEventHandler will roll back (increase) the inventory. However, the above inventory reduction action could be failed, which cause the inventory over-rollback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant