You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently to set the python module name to test in the sanity check the syntax is: "options={'modulename':'newname'}". The request is to change it to simply "modulename='newname'".
The text was updated successfully, but these errors were encountered:
It doesn't get better there. So the requested change only applies to "root" PythonPackage. It looks like it is the only entry used from "self.options" so it indeed makes sense and I guess for extensions that would just work.
There should also be a more intuitive (and documented...) way of skipping the import check than setting modulename to False...
That is only done for extensions isn't it? We should do it for PythonPackage too. Also note that "skipping the import check" also means that --skip won't work. So IMO we should just better document the behavior as I think modulename: False is clear enough for the only valid use case I can imagine: There is no package which could be imported.
Currently to set the python module name to test in the sanity check the syntax is: "options={'modulename':'newname'}". The request is to change it to simply "modulename='newname'".
The text was updated successfully, but these errors were encountered: