PSI easyblock is broken, install_step fails

[boegel]

Despite efforts for last-minute fixes, the PSI easyblock is broken.

The installation fails because os.path.basename yields an empty string when called on a path that ends with a /, i.e. os.path.basename("/path/to/psi/") returns "".

Because of this, the PSI builds fails as follows:

== 2013-10-04 15:00:38,528 main.EB_PSI ERROR EasyBuild crashed with an error (at easybuild/easyblocks/p/psi.py:133 in install_step): Failed to copy obj and unpacked sources to install dir: [Errno 17] File exists: '/path/to/software/PSI/4.0b4-ictce-4.1.13-mt/'

This problem will be fixed in EasyBuild v1.9, together with adding support for the new PSI version 4.0b5 (see easybuilders/easybuild-easyconfigs#434).

[wpoely86]

Fixed in #270

[boegel]

Actually, no, it's not fixed.

The problem is the following line in install_step:

for subdir in ['obj', os.path.basename(self.cfg['start_dir'])]:

The second element of that list will be "" (empty string), which makes the installation fail...

Can you fixed that in #270, and retest a PSI build to make 100% sure?

[wpoely86]

I will fix it but retest a PSI build will take a couple of hours...

[boegel]

I realize that, but EasyBuild v1.8.0 is out already anway (with the bug, elas :().

[wpoely86]

Fully fixed in #270.

[boegel]

follow-up via #270