Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of config.guess used by ConfigureMake #2826

Closed
ocaisa opened this issue Nov 11, 2022 · 6 comments · Fixed by #3013
Closed

Update version of config.guess used by ConfigureMake #2826

ocaisa opened this issue Nov 11, 2022 · 6 comments · Fixed by #3013
Assignees
Labels
Milestone

Comments

@ocaisa
Copy link
Member

ocaisa commented Nov 11, 2022

The version of config.guess that we use is from 2018. Looking at https://git.savannah.gnu.org/cgit/config.git/log/config.guess it is probably important that we update it for RISC-V support

@boegel boegel added the update label Nov 11, 2022
@boegel boegel added this to the next release (4.6.3?) milestone Nov 11, 2022
@boegel
Copy link
Member

boegel commented Nov 11, 2022

I agree we should use a more recent config.guess, but hopefully this won't lead to nasty surprises, since it will be difficult to ensure we don't introduce any regressions by doing so...

We should also use a cgit download URL, see https://git.savannah.gnu.org/cgit/config.git/commit/config.guess?id=888c8e3d5f7bf7464bba83aaf54304a956eefa60

@boegel
Copy link
Member

boegel commented Nov 11, 2022

In addition, we should check if we should also download config.sub alongside config.guess

@ocaisa
Copy link
Member Author

ocaisa commented Nov 11, 2022

I'm thinking about adding CONFIG_GUESS_VERSION as part of the config.guess filename. That way every version of EB will always use the same version of the file. Right now, if you we update the eb version and then someone uses an older version of eb to install something you will get an error about the checksum/dates not matching.

@ocaisa
Copy link
Member Author

ocaisa commented Nov 11, 2022

I looked into config.sub and according to the docs:

configure recognizes short aliases for many system types; for example, decstation can be used instead of mips-dec-ultrix4.2. configure runs a script called config.sub to canonicalize system type aliases.

It's a good bit of work to add config.sub and I don't see it having any value for us since we are getting the system type from config.guess

@boegel
Copy link
Member

boegel commented Oct 6, 2023

I'm thinking about adding CONFIG_GUESS_VERSION as part of the config.guess filename. That way every version of EB will always use the same version of the file. Right now, if you we update the eb version and then someone uses an older version of eb to install something you will get an error about the checksum/dates not matching.

That's only true for the develop branch (if you go back to an old commit in develop), since there's a separate config.guess downloaded for every EasyBuild version.

@boegel
Copy link
Member

boegel commented Oct 6, 2023

fixed in #3013

@boegel boegel closed this as completed Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants