Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threaded mpi should be disabled by default in SCOTCH for all toolchains #2972

Closed
Micket opened this issue Aug 2, 2023 · 4 comments
Closed
Milestone

Comments

@Micket
Copy link
Contributor

Micket commented Aug 2, 2023

# For backwards compatability of v2.8.0 this is necessary but could be removed on a major version upgrade
mpi_family = self.toolchain.mpi_family()
if self.cfg['threadedmpi'] is None and mpi_family not in [toolchain.INTELMPI, toolchain.QLOGICMPI]:
cflags += " -DSCOTCH_PTHREAD"

Comment indicates that it should have been dropped a long time ago. Lets do it for EB 5.0

@Micket Micket added this to the 5.0 milestone Aug 2, 2023
@boegel
Copy link
Member

boegel commented Aug 2, 2023

Is this specific to SCOTCH?

@Micket Micket changed the title Threaded mpi should be disabled by default for all toolchains Threaded mpi should be disabled by default in SCOTCH for all toolchains Aug 2, 2023
@Micket
Copy link
Contributor Author

Micket commented Aug 2, 2023

I forgot to say scotch, yes, specifically scotch.

@boegel
Copy link
Member

boegel commented Oct 23, 2023

@Micket This can be closed thanks to #3019?

@Micket
Copy link
Contributor Author

Micket commented Oct 23, 2023

I thought it would have been automatically since i used the "Fixes ..." syntax

@Micket Micket closed this as completed Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants