New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent license variable naming #3043

Open

Micket opened this issue Nov 29, 2023 · 1 comment

Labels

change request EasyBuild-5.0

Contributor

Micket commented Nov 29, 2023

We currently have a wide selection of license variable names in use. Grepping through the easyblocks we find for example:

LM_LICENSE_FILE
INTEL_LICENSE_FILE
ABAQUSLM_LICENSE_FILE
EB_MATLAB_LICENSE_SERVER
LMCOMSOL_LICENSE_FILE

so, it's either

LM_xxx
NAME_xxx
NAMELM_xxx
LMNAME_xxx
EB_NAME_xxx

I was going to suggest to stick to just one pattern:

EB_NAME_LICENSE_FILE
EB_NAME_LICENSE_SERVER
EB_NAME_LICENSE_PORT

The text was updated successfully, but these errors were encountered:

Micket added EasyBuild-5.0 change request labels

Contributor Author

Micket commented Nov 29, 2023

Doesn't really need to wait for 5.0 i guess, I'll just change COMSOL to use this syntax to reduce the variations a bit as a start. #3044

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment