Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent use of versionsuffix for Java #16038

Open
Micket opened this issue Aug 12, 2022 · 0 comments
Open

Inconsistent use of versionsuffix for Java #16038

Micket opened this issue Aug 12, 2022 · 0 comments
Milestone

Comments

@Micket
Copy link
Contributor

Micket commented Aug 12, 2022

First, we have been sloppy with versionsuffixes for Java.

E.g.

  • ant-1.10.12-Java-17.eb
  • Nextflow-22.04.0.eb (depends on Java-11)
  • ANTLR-2.7.7-GCCcore-11.3.0-Java-11.eb (uses the "2022a" toolchain hierarchy default)
  • Bazel-5.1.1-GCCcore-11.3.0.eb (depends on Java-11)

so maximum inconsistency here.

I'd say that at least every SYSTEM level Java app should include a suffix since they are independant of toolchain versions, there is no "default". That means Nextflow should have added a suffix here.
For things under toolchains, for anything that needs the non-default Java, adding the suffix should of course be done.

That leaves stuff like ANTLR and Bazel. There is no harm in adding the suffix for added visibility so I don't mind if we just add it to everything.

@boegel boegel added this to the 4.x milestone Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants