Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect download failure due to outdated certificate and print helpful warning? #3863

Closed
boegel opened this issue Oct 18, 2021 · 3 comments
Closed
Milestone

Comments

@boegel
Copy link
Member

boegel commented Oct 18, 2021

With the expiration of the Let's Encrypt root certificate, several people are running into download issues if their ca-certificates RPM, or equivalent, is not up-to-date; see for example easybuilders/easybuild-easyconfigs#14138:

 <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:618)>

Maybe we can/should recognize the error message that pops up when a download fails due to certificate issues, and produce a helpful warning to a link in the EasyBuild docs in this case?

edit: see also https://it.slashdot.org/story/21/10/02/2318202/millions-experience-browser-problems-after-long-anticipated-expiration-of-lets-encrypt-certificate

@boegel boegel added this to the 4.5.0 (next release) milestone Oct 18, 2021
@boegel
Copy link
Member Author

boegel commented Oct 22, 2021

One thing I do wonder if this could lead to (many?) false positive warnings, where some download indeed failed, but then succeeds just fine later.

So ideally we post-pone printing the warning until all source URLs have been tried, maybe?

@JorisRommelse
Copy link

Downloads can go wrong for millions of reasons. Why catch one and include it in a warning? It already goes to the log. I think it needs to be decided whether it should go to the screen as well, or not. But I would not send one reason to screen and one million minus one to log.

@boegel
Copy link
Member Author

boegel commented Jan 14, 2022

I'll close this, the certificate verification failure could indeed have any number of reasons, so it wouldn't really be possible to come up with a meaningful truly helpful error message.

If anything, this issue can serve as a hint to what could be wrong.

@boegel boegel closed this as completed Jan 14, 2022
@boegel boegel modified the milestones: next release (4.5.2?), 4.x Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants