Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename unclear ExtensionEasyblock.run() method #4113

Closed
lexming opened this issue Oct 26, 2022 · 1 comment
Closed

rename unclear ExtensionEasyblock.run() method #4113

lexming opened this issue Oct 26, 2022 · 1 comment
Labels
change request EasyBuild-5.0 EasyBuild 5.0
Milestone
5.0

Comments

@lexming
Copy link
Contributor

lexming commented Oct 26, 2022

The run() method from extensioneasyblock is the one carrying out the installation of any extension. Its name should be changed to something more meaningful that reflects its function more clearly. For instance run_extension_steps().
@lexming lexming added this to the 5.0 milestone Oct 26, 2022
@boegel boegel changed the title rename unclear extensioneasyblock.run() method rename unclear ExtensionEasyblock.run() method May 3, 2023
@boegel boegel added the EasyBuild-5.0 EasyBuild 5.0 label May 23, 2023
@lexming lexming mentioned this issue Dec 12, 2023
Merged
@lexming
Copy link
Contributor Author

lexming commented Mar 11, 2024

fixed in #4400

@lexming lexming closed this as completed Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
change request EasyBuild-5.0 EasyBuild 5.0
Projects
None yet
Milestone
5.0
Development

No branches or pull requests
2 participants
@boegel @lexming