Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub integration check falsely reports gist creation issues #4230

Closed
bedroge opened this issue Mar 28, 2023 · 2 comments · Fixed by #4231
Closed

GitHub integration check falsely reports gist creation issues #4230

bedroge opened this issue Mar 28, 2023 · 2 comments · Fixed by #4231
Milestone

Comments

@bedroge
Copy link
Contributor

bedroge commented Mar 28, 2023

I'm getting the following when running eb --check-github with a personal access token that really has the proper gists permission:

Checking status of GitHub integration...

Making sure we're online...OK

* GitHub user...bedroge => OK
* GitHub token...ghp..MW0 (len: 40) => OK (validated)
* git command...OK ("git version 2.31.1; ")
* GitPython module...OK (GitPython version 3.1.18)
The authenticity of host 'github.com (140.82.121.3)' can't be established.
ECDSA key fingerprint is SHA256:p2QAMXNIC1TJYWeIOttrVc98/R1BUFWu3/LiyKgUfQM.
Are you sure you want to continue connecting (yes/no/[fingerprint])? yes
* push access to bedroge/easybuild-easyconfigs repo @ GitHub...OK
* creating gists...FAIL (gist_url: https://gist.github.com/bedroge/6e0503bc018f7de1a7d63f3e994b0c71)
* location to Git working dirs... OK (/home1/p251204/easybuild)

One or more checks FAILed, GitHub configuration not fully complete!
See http://easybuild.readthedocs.org/en/latest/Integration_with_GitHub.html#configuration for help.

Status of GitHub integration:
* --from-pr: OK
* --new-pr: OK
* --review-pr: OK
* --update-pr: OK
* --upload-test-report: not supported

@branfosj just confirmed he's seeing the same issue. Interestingly, things seem to work fine anyway (it uploaded this test report right after running the above command: easybuilders/easybuild-easyconfigs#17610 (comment)), so it looks like there's something wrong with this check.

@branfosj
Copy link
Member

We match on

re.match('https://gist.github.com/[0-9a-f]+$', gist_url)

However, the gist_url now includes github username: https://gist.github.com/branfosj/b4087b3584dd92133f3bbc1d995759b6

@branfosj
Copy link
Member

Changing it to

re.match('https://gist.github.com/%s/[0-9a-f]+$' % github_user, gist_url):

seems to solve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants