Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include entire flag in optarch (instead of excluding the initial dash) and maybe make it only per-compiler #4269

Open
Micket opened this issue Jun 5, 2023 · 0 comments
Milestone

Comments

@Micket
Copy link
Contributor

Micket commented Jun 5, 2023

The exclusion of the initial - from optarch strings is a confusing historical mistake. It looks especially weird when multiple flags are used, as it just append the initial -, so one ends up with stuff like

optarch = "march=x86-64 -mtune=generic"

which is just odd. If we also try to expand this into other compilers, Java, Rust, Go etc, we'd end up with things like C target-cpu=generic for Rust etc, which really just looks really strange.

At the same time, looking at multiple different compilers nvhpc vs gcc vs intel which don't have a unified set of flags (as well as more languages like Rust and Go where flags are completely different per compiler), we really don't have any chance of specifying general optarch; only the per-compiler version makes can work in general.

@boegel boegel added this to the 5.0 milestone Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants