Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement hook to run after easyconfigs are parsed but before the build starts #4303

Closed
XavierCS-dev opened this issue Jul 25, 2023 · 4 comments · Fixed by #4304
Closed

Implement hook to run after easyconfigs are parsed but before the build starts #4303

XavierCS-dev opened this issue Jul 25, 2023 · 4 comments · Fixed by #4304
Milestone

Comments

@XavierCS-dev
Copy link
Contributor

A hook that is run which is passed all of the easyconfigs would be very helpful. It would be passed a copy of ordered_ecs, so it can extract information from it.

The hook would then use the knowledge about all the easyconfigs to be built for various operations such as notifying external tools about the number of easyconfigs, and what they are, which could even be used to estimate build time.

I plan to implement this feature myself

@XavierCS-dev
Copy link
Contributor Author

I am struggling to think of a name for such a hook, how do you feel about "poised hook"?

@boegel
Copy link
Member

boegel commented Aug 2, 2023

I like this idea of this extra hook, but I'm not sure whether "poised" is a good name for it...

At least to me (as a non-native English speaker), the term is meaningless to me.
And looking up the term doesn't help me much (see https://www.merriam-webster.com/dictionary/poised for example).

In addition, there should be a pre and post variant of this hook imho: the pre being triggered right before EasyBuild starts looping over the installations to perform, the post being triggered right after (small difference with the end hook), but in the build_and_install_software function?

I'm also struggling to find a good name, but how about pre_iter and post_iter (before/after iterating over all installations to perform)?
Or maybe pre_loop and post_loop?

@XavierCS-dev
Copy link
Contributor Author

With regards to there being a pre and post hook, this certainly makes sense and is something I can do.
Concerning the name, possibly pre_loop and post_loop. I am not sure though, neither quite feel "right" to me, but both could be more meaningful than poised.

@branfosj
Copy link
Member

branfosj commented Aug 8, 2023

We've decided on pre_build_and_install_loop and post_build_and_install_loop.

@boegel boegel modified the milestones: 4.x, 4.8.1 Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants