Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub tests fail in CI because we're hitting GitHub API rate limit #4372

Closed
boegel opened this issue Oct 29, 2023 · 3 comments · Fixed by #4375
Closed

GitHub tests fail in CI because we're hitting GitHub API rate limit #4372

boegel opened this issue Oct 29, 2023 · 3 comments · Fixed by #4375

Comments

@boegel
Copy link
Member

boegel commented Oct 29, 2023

Since the changes proposed in #4192 by @Flamefire have been merged, we're more frequently seeing failing GitHub-related tests in the develop branch (when a GitHub token is available that can be used to run the GitHub tests).

We'll need to revisit the configuration, to only install the available GitHub token is less configurations, for example only when testing with Lua as module syntax, and maybe even only for selected Python versions (only for Python 3.6, default in RHEL8-based OSs, and Python 3.9, default for RHEL9-based OSs).

@boegel
Copy link
Member Author

boegel commented Oct 29, 2023

I had to bypass the branch protection to get #4370 merged when releasing EasyBuild v4.8.2 because of this, it's especially a pain when releasing EasyBuild...

@Flamefire
Copy link
Contributor

Ouch, that is a bummer: By avoiding one kind of rate limit we run into another. Maybe the step to install the token should be removed entirely and the token only installed for specific jobs (e.g. in the include part define a use_token: True for some jobs similar to modules_tool: xxx) and as you suggested only when running the LUA part of the loop at https://github.com/easybuilders/easybuild-framework/pull/4192/files#diff-c91058a32040621ac54d6ea4194b302a420b7849f6e8561920d23a0e97acf69aR175

I guess we have to switch the order (first Tcl then Lua) or remove the token afterwards

@boegel
Copy link
Member Author

boegel commented Oct 30, 2023

Indeed, that would make sense.
Tcl first is probably way easier than removing the token.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants