Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make --job a bit smarter when uploading test reports #4387

Open
jfgrimm opened this issue Nov 23, 2023 · 2 comments
Open

make --job a bit smarter when uploading test reports #4387

jfgrimm opened this issue Nov 23, 2023 · 2 comments
Milestone

Comments

@jfgrimm
Copy link
Member

jfgrimm commented Nov 23, 2023

Currently, -r --job --from-pr will generate one test report per submitted job, and post that as a comment on the PR. Particularly when building something depending on a new toolchain, this can spawn a lot of jobs (resulting in a lot of separate comments) for a single PR.

@jfgrimm jfgrimm added this to the 4.x milestone Nov 23, 2023
@boegel
Copy link
Member

boegel commented Dec 6, 2023

@jfgrimm That tells me that we should essentially disable --robot when --from-pr is combined with --job?

Or perhaps only if --upload-test-report is also used?

@branfosj
Copy link
Member

branfosj commented Dec 6, 2023

Definitely we should disable it when --upload-test-report is used.

When just --from-pr is used with --job it allows someone to build up the stack of software up to that PR using the job functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants