Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Conditionally enable the bundle #3

Closed
xabbuh opened this issue May 24, 2017 · 0 comments · Fixed by #5
Closed

[Documentation] Conditionally enable the bundle #3

xabbuh opened this issue May 24, 2017 · 0 comments · Fixed by #5

Comments

@xabbuh
Copy link
Contributor

xabbuh commented May 24, 2017

Currently, the docs suggest to enable the bundle in the AppKernel as follows:

// ...
class AppKernel extends Kernel
{
    public function registerBundles()
    {
        $bundles = array(
            // ...
            new EasyCorp\Bundle\EasyDeployBundle\EasyDeployBundle(),
        );

        // ...
    }

    // ...
}

However, doing so will break your application after deploying as the bundle will not be installed on your production environment (it's been installed as a dev dependency when following the installation instructions).

javiereguiluz added a commit that referenced this issue May 24, 2017
…viereguiluz)

This PR was merged into the 1.0.x-dev branch.

Discussion
----------

[Doc] Don't recommend to enable the bundle in production

This fixes #3.

Commits
-------

d78d7e9 [Doc] Don't recommend to enable the bundle in production
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant