Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show '$0.00' as 'Free' #1109

Closed
pippinsplugins opened this issue Apr 22, 2013 · 2 comments
Closed

Show '$0.00' as 'Free' #1109

pippinsplugins opened this issue Apr 22, 2013 · 2 comments
Labels
type-feature
Milestone
v1.7

Comments

@pippinsplugins
Copy link
Contributor

A price tag of $0.00 doesn't make a lot of sense. We should filter product prices that are 0.00 and shoe them as Free instead.

@sumobi has written a basic plugin to handle this, though there are a few scenarios not accounted for in his plugin.

I've started work on this by implementing a few more filters that are needed.

Note, only the product prices should change to Free, not the cart amounts, taxes, etc.
pippinsplugins added a commit that referenced this issue Apr 22, 2013
@pippinsplugins
Added new edd_get_download_price filter. #1109
483b02a
pippinsplugins added a commit that referenced this issue Apr 22, 2013
@pippinsplugins
Added new edd_format_amount filter. #1109
67566d9
@pippinsplugins
Copy link
Contributor Author

Punted to 1.7.

sunnyratilal added a commit that referenced this issue Jun 29, 2013
@sunnyratilal
Show '$0.00' as 'Free'. See #1109.
e8f7b0d
@pippinsplugins
Copy link
Contributor Author

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-feature
Projects
None yet
Milestone
v1.7
Development

No branches or pull requests
1 participant
@pippinsplugins