Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update register_meta() for WP 4.6 #4807

Closed
pippinsplugins opened this issue Jul 19, 2016 · 12 comments
Closed

Update register_meta() for WP 4.6 #4807

pippinsplugins opened this issue Jul 19, 2016 · 12 comments
Assignees
Milestone

Comments

@pippinsplugins
Copy link
Contributor

WP 4.6 is changing how register_meta() works. We need to update our use of it to match while also maintaining backwards compatibility for pre 4.6

@pippinsplugins pippinsplugins added this to the 2.6.5 milestone Jul 19, 2016
@pippinsplugins
Copy link
Contributor Author

@cklosowski
Copy link
Contributor

@pippinsplugins @chriscct7 can you guys look over that commit. I've not applied the patch and things seems to still be working. Curious if I interpreted the needed updates differently than I did.

@pippinsplugins
Copy link
Contributor Author

I'm pretty sure that is correct.

@sunnyratilal
Copy link
Contributor

All looks good to me

@cklosowski
Copy link
Contributor

There is an open issue #4523 where we need to do some extra sanitization of prices, I'm going include that in this issue as well.

@pippinsplugins
Copy link
Contributor Author

@pippinsplugins
Copy link
Contributor Author

@sunnyratilal we'll need this retested shortly once @cklosowski pushes up some changes for the adjustments just made to core.

@sunnyratilal
Copy link
Contributor

Can confirm all is working:

  1. Meta is being registered in the WordPress global $wp_meta_keys
  2. register_meta() returns true as expected.

Good to merge methinks.

@sunnyratilal
Copy link
Contributor

I'm setting up instances of WordPress 4.5.x to ensure backwards compatibility.

@sunnyratilal
Copy link
Contributor

Backwards compatibility is maintained with all versions of WordPress 4.5.x (4.5 -> 4.5.3). No bugs found for me.

@cklosowski
Copy link
Contributor

@sunnyratilal did you get a chance to verify that this branch also resolves #4523 ?

pippinsplugins added a commit that referenced this issue Jul 21, 2016
Update register_meta and don't allow negative prices by default #4807 #4523
@pippinsplugins
Copy link
Contributor Author

All good here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants