Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0: Improve discount code bulk deletion messaging #6807

Closed
mindctrl opened this issue Jul 27, 2018 · 2 comments
Closed

3.0: Improve discount code bulk deletion messaging #6807

mindctrl opened this issue Jul 27, 2018 · 2 comments

Comments

@mindctrl
Copy link
Contributor

Bug Report

Expected behavior

In 3.0 if a discount has been used, the UI doesn't allow you to delete it. Great. However, when using bulk actions, if you select discounts that have been used and select Delete from the list, the page reloads and gives no indication that the codes were not deleted.

It would be nice to show a message to indicate that they were not deleted.

Information (if a specific version is affected):

EDD Version (or branch): release/3.0

@sunnyratilal
Copy link
Contributor

9ab4a08

sunnyratilal added a commit that referenced this issue Aug 22, 2018
@sunnyratilal
Copy link
Contributor

After a discussion in Slack with @JJJ, we've decided the best way of moving forward with this is to disable the checkbox if a discount cannot be deleted. It makes sense in terms of UX and a message has been added to the checkbox via the title attribute to let the user know why the checkbox has been disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants