Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential LhFreeMemory call on random pointer #38

Closed
pzychotic opened this issue Aug 29, 2015 · 1 comment
Closed

Potential LhFreeMemory call on random pointer #38

pzychotic opened this issue Aug 29, 2015 · 1 comment
Labels
Milestone

Comments

@pzychotic
Copy link

Hi,

in LhAllocateHook() the variable Hook isn't initialized with NULL and the first assignment is only done after three potential THROW calls.
So we might end in the THROW_OUTRO happily passing the null pointer check and calling LhFreeMemory() on a random pointer.

@justinstenning
Copy link
Member

Thanks @pzychotic - I've run through and checked every other compiler warning and addressed appropriately also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants