Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YouTube.com Bypassing Adblock? #937

Closed
elaine-jackson opened this issue Mar 1, 2018 · 9 comments
Closed

YouTube.com Bypassing Adblock? #937

elaine-jackson opened this issue Mar 1, 2018 · 9 comments

Comments

@elaine-jackson
Copy link

List the website(s) you're having issues:

What happens?

YouTube appears to be bypassing Adblock Plus and displaying advertisements. One thing to note is I run a Pi-hole on my WiFi Network that performs DNS Based Adblocking, I doubt it's causing this issue but it's worth noting.

List Subscriptions you're using:

Your settings

  • OS/version: macOS High Sierra
  • Browser/version: Safari
  • Adblock Extension/version: Adblock Plus

Other details:

screen shot 2018-03-01 at 8 30 47 am

screen shot 2018-03-01 at 8 35 46 am

@elaine-jackson
Copy link
Author

I'm going to ad that after switching to uBlock Origin the issue stopped, this is exclusive to Adblock Plus, the question is why. I might open up an issue with Adblock Plus. Let me know if the easylist team has any thoughts on this.

@ryanbr
Copy link
Member

ryanbr commented Mar 1, 2018

If you hit "F12" during the ads showing and show a list of Adblock elements being hit, might help here.

@elaine-jackson
Copy link
Author

@ryanbr The issue seems to be Adblock Plus Safari Exclusive, I was not allowing non intrusive ads, it wouldn't surprise me if they snuck code in allowing YouTube Ads regardless of setting or list. People reading this will call me paranoid or say I can't prove it, and they'd be right, then again only Adblock Plus has this issue, switching to uBlock Origin fixed it, I reported the issue on their forum. I figured I'd make you guys aware as well.

@ryanbr
Copy link
Member

ryanbr commented Mar 1, 2018

If there is bug, report it; https://issues.adblockplus.org/ then every safari user will benefit :)

@ryanbr ryanbr closed this as completed Mar 1, 2018
@elaine-jackson
Copy link
Author

@ryanbr Would you consider re-opening this issue? I just had the same issue with uBlock Origin. This doesn't seem to be Adblock Plus specific anymore.
screen shot 2018-03-01 at 7 46 53 pm

@crusader-mike
Copy link

FYI -- not exclusive to safari anymore. Since today my Chrome shows ads on youtube (Win7)

@crusader-mike
Copy link

crusader-mike commented Mar 12, 2018

Hmm... I removed it, closed all chrome instances, installed it again and problem went away. Looks like it's state got corrupted or smth. I've been getting a lot of crashes watching certain type of youtube videos for ~10 mins (I suspect a hardware problem -- certain games (like Witcher3) were doing the same after about 10 mins of play). Working theory -- during crash smth happened to adblock. Maybe chrome blamed it for my youtube crashes and blocked it somehow on related webpage?

@elaine-jackson
Copy link
Author

@crusader-mike Like I've said over Twitter, GitHub, and to people in the security community it wouldn't surprise me if Team YouTube is exploiting a security issue in Adblock + uBlock. I do not have conclusive proof however it's difficult to get that proof.

It's worth mentioning that should my suspicions be correct, it would be very "ungoogly" as Google has contributed a lot to the security community, it'd be very out of character for them to knowingly exploit a security issue rather than report it and contribute to a fix.

@crusader-mike
Copy link

@nsuchy FYI: about those crashes -- I figured out why. Overclocked memory triggered crashes with certain video codecs (I imagine certain codecs use GPU<->main memory DMA transfer quite a bit and that mechanism is more sensitive to memory timings, than usual CPU <-> main memory). Resetting memory timings in BIOS caused all crashes to go away.

I bet those crashes caused either corruption of ADBlock state (maybe corruption of Chrome extension manager state?) or maybe caused Chrome to mark ADBlock as unstable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants