Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Parser class abstract #328

Closed
njh opened this issue Jun 27, 2020 · 2 comments · Fixed by #358
Closed

Make Parser class abstract #328

njh opened this issue Jun 27, 2020 · 2 comments · Fixed by #358
Milestone
1.1.0

Comments

@njh
Copy link
Collaborator

njh commented Jun 27, 2020

Serialiser class was made abstract in:

  • ba4806e088b64f6918b66df52c2df5b0eb685777
  • 5af0be7f32ca8fc3acb8aaf1ebe1e05a964dec0e
@njh njh added this to the 1.1.0 milestone Jun 27, 2020
@k00ni
Copy link
Contributor

k00ni commented Jul 21, 2020

What benefits do we get for making it abstract?

Couldn't that be a backward compatibility break and therefore requires a new major version?

@k00ni
Copy link
Contributor

k00ni commented Sep 7, 2020

Couldn't that be a backward compatibility break and therefore requires a new major version?

Answer myself: It wouldn't be an API break, because it only had one public method which throws an exception if used directly (it had to be overridden).

@k00ni k00ni mentioned this issue Sep 7, 2020
Merged
@njh njh closed this as completed in #358 Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

Made parser class abstract; fixed related test case easyrdf/easyrdf
2 participants
@njh @k00ni