Add possibility to select arbitrary elements #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up to now, an element has to have an 'id' attribute to be able to get an popover/tooltip. This was hardcoded in the underlying Javascript. A new parameter was added to add[Tooltip|Popover] to override the default behaviour to look for the element by id. With this flag set, the user can provide an arbitrary jQuery selector as 'id'. The argument name 'id' is maybe misleading in this case, but this approach seemed to be minimal evasive and should not be breaking old code. Closes: ebailey78#124
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up to now, an element has to have an 'id' attribute to be able to get
an popover/tooltip. This was hardcoded in the underlying Javascript. A
new parameter was added to add[Tooltip|Popover] to override the default
behaviour to look for the element by id. With this flag set, the user
can provide an arbitrary jQuery selector as 'id'.
The argument name 'id' is maybe misleading in this case, but this
approach seemed to be minimal evasive and should not be breaking old
code.
Closes: #124