Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant "out-side" label and final model training. #21

Open
danbogu opened this issue Jun 15, 2021 · 3 comments
Open

Redundant "out-side" label and final model training. #21

danbogu opened this issue Jun 15, 2021 · 3 comments

Comments

@danbogu
Copy link

danbogu commented Jun 15, 2021

Hi,
When using a labeled data where "non-entity" words are already labeled with "O", 'tag_ouside' variable set to "O" adds a label and makes the input tensor dimensions incorrect (by 1 unit).

Also, when training final model after hyperparameter tuning on full data, is there a way to disable validation set while training?

@smaakage85
Copy link
Contributor

Hi @danbogu

First and foremost - thanks for the feedback, it is much appreciated :)

When using a labeled data where "non-entity" words are already labeled with "O", 'tag_ouside' variable set to "O" adds a label and makes the input tensor dimensions incorrect (by 1 unit).

Can you provide a reproducible example? It would make it much easier for me to investigate the matter. Besides from that, the tags of named entities should definitely be different from the special outside tag.

Also, when training final model after hyperparameter tuning on full data, is there a way to disable validation set while training?

Unfortunately not, but I am certainly open to the idea, and if you make a pull request on this, I will be happy to inspect it and merge it in :) Are you interested in this?

@danbogu
Copy link
Author

danbogu commented Aug 28, 2021

Hey @smaakage85,
About the first topic, at a later stage, I realized that I just need to omit 'O' from the tag_scheme I provide to solve the dimension exception.
If you still want me to provide a more detailed example I would be happy to do so.

Also, I am surely interested to try to resolve the second thing I mentioned. I have a few simple solutions implementations in my head. let's do it :)

@smaakage85
Copy link
Contributor

Sounds good @danbogu

Looking forward to your pull request :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants