Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label hacktoberfest #517

Closed
shriyaMadan opened this issue Oct 7, 2020 · 4 comments · Fixed by #502
Closed

Add label hacktoberfest #517

shriyaMadan opened this issue Oct 7, 2020 · 4 comments · Fixed by #502

Comments

@shriyaMadan
Copy link
Contributor

I am bringing this to your knowledge that contributes to this repository is not counting in the Hacktoberfest as there is no label of Hacktoberfest
PS: "hacktoberfest2020" is not an acceptable label under Hacktoberfest guidelines.

@github-actions
Copy link

github-actions bot commented Oct 7, 2020

Hello @shriyaMadan , thank you for submitting an issue! 👍 We highly appreciate if you work on it as well.

@Ebazhanov
Copy link
Owner

You are right, but there also wiritten that you can Submit your PR in a repo with the hacktoberfest topic!

PRs count if:
Submitted during the month of October AND
Submitted in a public repo AND (
  The PR is labelled as hacktoberfest-accepted by a maintainer OR
  Submitted in a repo with the hacktoberfest topic AND (
    The PR is merged OR
    The PR has been approved
  )
)

===>>>> reference link

@shriyaMadan
Copy link
Contributor Author

You are right, but there also wiritten that you can Submit your PR in a repo with the hacktoberfest topic!

PRs count if:
Submitted during the month of October AND
Submitted in a public repo AND (
  The PR is labelled as hacktoberfest-accepted by a maintainer OR
  Submitted in a repo with the hacktoberfest topic AND (
    The PR is merged OR
    The PR has been approved
  )
)

===>>>> reference link

Yeah, that's what I wrote.

@Ebazhanov Ebazhanov linked a pull request Oct 12, 2020 that will close this issue
@Ebazhanov
Copy link
Owner

FYI @shriyaMadan updated your PR according to requirements -> hacktoberfest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants