Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with findSingleAttributeList - queries and oneToMany relations #2746

Closed
AlexWagner opened this issue Jul 13, 2022 · 2 comments
Closed
Assignees
Milestone

Comments

@AlexWagner
Copy link
Contributor

Hi there.
I added some tests for findSingleAttributeList in Class TestQuerySingleAttribute.
Focus are queries on oneToMany relations (Query on customer, oneToMany-Field: orders.status)

some queries don't work as they produce invalid sql
some queries deliver wrong result

See PR in our fork: FOCONIS#68

@rbygrave
Copy link
Member

I'd ask to focus on 1 thing / 1 failing test and generally include an assert on the expected SQL and for a case where the SQL is not what is expected put a comment in for what the invalid SQL produced is.

Can you pick one failing case and produce a PR for that?

@rbygrave
Copy link
Member

I think we have resolved those now. I'll close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants