Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction id in the end of redirect_url #1

Closed
janjiss opened this issue Jan 8, 2013 · 5 comments
Closed

Transaction id in the end of redirect_url #1

janjiss opened this issue Jan 8, 2013 · 5 comments

Comments

@janjiss
Copy link
Contributor

janjiss commented Jan 8, 2013

Hi there,
Right now I need to add trans_id to params manualy in controller like this:

@gateway.redirect_url + "?trans_id=#{CGI.escape response['transaction_id']}"

I think this transaction id should be added automaticly in redirect_url action, don't you think?
If you agree, then I'll make pull request.

Have a nice day :)

@ebeigarts
Copy link
Owner

I don't it will be possible to add it automatically, but I would prefer @gateway.redirect_url(trans_id)

@ebeigarts
Copy link
Owner

PR is welcome :)

@janjiss
Copy link
Contributor Author

janjiss commented Jan 8, 2013

Is there a possibility, that there is no need for transaction id?

@ebeigarts
Copy link
Owner

I don't think so but let's leave redirect_url method backwards compatible, maybe an optional param -

def redirect_url(trans_id=nil)
...
end

@ebeigarts
Copy link
Owner

This was fixed in #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants