Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to virt_jena3.jar and Apache Jena 3.10.0 #23

Open
danizen opened this issue Nov 14, 2016 · 2 comments
Open

Update to virt_jena3.jar and Apache Jena 3.10.0 #23

danizen opened this issue Nov 14, 2016 · 2 comments

Comments

@danizen
Copy link
Contributor

danizen commented Nov 14, 2016

Currently, lode-virtuoso-impl depends on an artifact virt_jena. It seems likely to come from
https://github.com/openlink/virtuoso-opensource/tree/develop/7/binsrc/jena, but I'm not 100% sure as it must be injected from elsewhere.

Correspondence on the virtuoso-users mailing list reveals that we should be using the JAR virt_jena2.jar from https://github.com/openlink/virtuoso-opensource/tree/develop/7/binsrc/jena2 for Apache Jena 2.13

This issue requests that we:

  • Make it clear through comments in the pom.xml where this comes from, and change the versionId to correspond to releases of the virtuoso-opensource repository.
  • Upgrade to virt_jena2.jar and call the artifact virt_jena2
  • Upgrade to Apache Jena 2.13.0

Possibly, it would be good to have a shell script or ant build to download these artifacts locally, and add them to a local repository.

@danizen
Copy link
Contributor Author

danizen commented Mar 25, 2019

Changing target to Jena 3.10.0, which is what is used in virtuoso-opensource, at least in the develop/7 branch.

@danizen danizen changed the title Update to virt_jena2.jar and Apache Jena 2.13 Update to virt_jena3.jar and Apache Jena 3.10.0 Mar 25, 2019
@danizen
Copy link
Contributor Author

danizen commented Mar 25, 2019

I just tested the pull request against my version Lodestar, my version's unit tests on-premise query against a Virtuoso 7 database, and so updating to virt-jena3.jar and Jena libs 3.10.0 doesn't break the ability to talk to an existing Virtuoso 7 database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant