Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page movement on search icon and EMBL-EBI logo mouseover #141

Open
mandarsd opened this issue Jul 31, 2018 · 4 comments
Open

Page movement on search icon and EMBL-EBI logo mouseover #141

mandarsd opened this issue Jul 31, 2018 · 4 comments

Comments

@mandarsd
Copy link

It looks like top margin is getting applied on mouseover.

@khawkins98
Copy link
Contributor

You're describing this, right?

kapture 2018-07-31 at 13 19 43

The idea here was to give a little "nudge" that there's a "slide out" drawer. But maybe that feels like a glitch, or it feels wrong?

@mandarsd
Copy link
Author

Yes! this one. It looks like a glitch to me because the entire page moves down.
I liked the idea behind the slide out. It would be nice if the sliding bit happens with 'absolute' position so the entire page won't move.

@khawkins98
Copy link
Contributor

It's actually not a position trick, but rather there's a 4px white border that's being animated in and out.

We could work around the "push down" by adding to the existing:

.masthead-black-bar {
  margin-bottom: 0;
  position: relative;
  z-index: 10;
}

.masthead-black-bar.peek {
    margin-bottom: -4px;
}

Here's what that looks like in Chrome (of course also need to check in other browsers).

kapture 2018-08-01 at 9 00 30

@mandarsd
Copy link
Author

mandarsd commented Aug 1, 2018

This looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants