-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin not constructing URLs correctly in 22.11.08 #130
Comments
Indeed we patched : To undo changes from 4f3e702 Looks like method get_plugin_http_path() is called but not defined |
Looks like this is also an issue for Koha 21.11 |
We tried updating our plugin. The version number matches the most recent release which includes this patch, but it isn't loading on our system. The plugin's last updated date shows as 2023-08-02. I will go back to our support company (ByWater) and see what they can do to get our plugin updated to use the most recent release. |
Hello! Thanks for reporting this. I know it was set as closed, but I'm curious if there's anything common between your Koha versions. We have a freshly installed version of 22.05 on Ubuntu and 22.11 on Debian and links are working as expected. The get_plugin_http_path() variable should be available to us when we import Koha (I thought). I'm pretty sure we were referencing this information https://perldoc.koha-community.org/Koha/Plugins/Base.html#get_plugin_http_path when initially setting all of this up, though if it's out of date I'm happy to revisit. Can you give me a step by step on what's going wrong? In trying to duplicate I'm: |
@mmabrahamson, Happy to provide more detail. We are running Koha 22.11 on a very old and decrepit 18.04 Ubuntu. We need to upgrade the OS and are trying to work through some internal issues to make that happen. Our plugins table shows that the Koha EDS API plugin version is 22.11001, but the last updated date is 2 August. ByWater already tried updating the plugin once, having seen in Github that the most recent update was 6 September, but nothing changed and we're still having the issue. Here's the steps that lead to our 404 errors:
It wasn't until I looked closely at the URLs that I discovered that almost all links to EDS records are missing "/plugin/Koha/Plugin/EDS" from the middle of the URLs. Only research starters seem to include it. |
We're running the most recent release of the plugin (22.11001) in Koha 22.11.08 and are seeing 404 errors when trying to view record details from EDS. It appears that the URL for the detailed record is leaving out "plugin/Koha/Plugin/EDS/".
Working URLs look like this:
https://[koha domain base URL]/plugin/Koha/Plugin/EDS/opac/eds-detail.pl?q=Retrieve?an=[EDS record identifiers]
Broken URLs look like this:
https://[koha domain base URL]/opac/eds-detail.pl?q=Retrieve?an=[EDS record identifiers]
In our Koha EDS-API installation, the only EDS records that have correctly formed URLs that work are the ones that point to research starters. Everything else (journal articles, ebooks, etc.) have incorrectly formed URLs that result in 404 errors.
This has also been submitted to EBSCO Connect. Our case number is 5564607.
The text was updated successfully, but these errors were encountered: