Skip to content
This repository has been archived by the owner on May 2, 2023. It is now read-only.

fix: programmatically setting the status of the drone builds #266

Merged
merged 12 commits into from Dec 23, 2019

Conversation

planctus
Copy link
Contributor

@planctus planctus commented Dec 12, 2019

PR description

Since the devops contacted could not apparently find the reason for this, i think we can apply this fix on our side, don't see downsides in doing it. In case the problem will get solved on the drone side we we can then remove this.

QA Checklist

In order to ensure a safe and quick review, please check that your PR follow those guidelines:

  • I have put the vanilla component as devDependencies
  • I have put the specs package as devDependencies
  • I have added the components directly used in the twig file (with include or embed) as dependencies
  • My component is listed in @ecl-twig/ec-components's dependencies
  • My variables naming follow the guidelines (snake case for twig)
  • I have provided tests
  • I have provided documentation (for the "notes" tab)
  • If my local yarn.lock contains changes, I have committed it
  • I have given my PR the proper label (pr: review needed to indicate that I'm done and now waiting for a review ,pr: wip to indicate that I'm actively working on it ...)

@planctus planctus changed the base branch from master to develop December 13, 2019 15:14
@planctus planctus changed the title Test drone fix: Test drone Dec 13, 2019
@planctus planctus added the pr: wip Mark the PR as WIP label Dec 13, 2019
@kalinchernev
Copy link
Contributor

Had a brief look for possible issues.
In drone drone.fpfis.eu/ all looked fine. Enabled webhook on pull_request in addition to push for just in case, although won't make any big difference. The https://drone.fpfis.eu/hook webhook is still installed on the repository on Github. Nothing wrong on our side and setup.

@planctus
Copy link
Contributor Author

@kalinchernev , thanks, i'm still in contact with the dev ops to see if they find the reason for this, worst case scenario this "manual" solution seems to work...

@planctus planctus changed the title fix: Test drone fix: programmatically setting the status of the drone builds Dec 20, 2019
@planctus planctus added pr: review needed Use this label to show that your PR needs to be review and removed pr: wip Mark the PR as WIP labels Dec 20, 2019
@planctus planctus merged commit d40a55e into develop Dec 23, 2019
@planctus planctus deleted the test-drone branch December 23, 2019 10:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr: review needed Use this label to show that your PR needs to be review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants