Skip to content
This repository has been archived by the owner on May 2, 2023. It is now read-only.

fix(site-headers): Logged in dropdown not opening - TWIG-184 #273

Merged
merged 3 commits into from Dec 20, 2019

Conversation

papegaill
Copy link
Contributor

PR description

Please drop a few lines about the PR: what it does, how to test it, etc.

QA Checklist

In order to ensure a safe and quick review, please check that your PR follow those guidelines:

  • I have put the vanilla component as devDependencies
  • I have put the specs package as devDependencies
  • I have added the components directly used in the twig file (with include or embed) as dependencies
  • My component is listed in @ecl-twig/ec-components's dependencies
  • My variables naming follow the guidelines (snake case for twig)
  • I have provided tests
  • I have provided documentation (for the "notes" tab)
  • If my local yarn.lock contains changes, I have committed it
  • I have given my PR the proper label (pr: review needed to indicate that I'm done and now waiting for a review ,pr: wip to indicate that I'm actively working on it ...)

@papegaill papegaill added the pr: review needed Use this label to show that your PR needs to be review label Dec 18, 2019
@planctus planctus added pr: under review and removed pr: review needed Use this label to show that your PR needs to be review labels Dec 18, 2019
Copy link
Contributor

@planctus planctus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think you forgot to apply the fix also to the site-header-core component.. ;)

@papegaill papegaill added pr: review needed Use this label to show that your PR needs to be review pr: wip Mark the PR as WIP and removed pr: modification needed pr: review needed Use this label to show that your PR needs to be review labels Dec 19, 2019
@papegaill papegaill added pr: review needed Use this label to show that your PR needs to be review and removed pr: wip Mark the PR as WIP labels Dec 19, 2019
@planctus planctus added pr: under review and removed pr: review needed Use this label to show that your PR needs to be review pr: under review labels Dec 20, 2019
@planctus planctus merged commit f921cda into develop Dec 20, 2019
@planctus planctus deleted the TWIG-184 branch December 20, 2019 14:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants