Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin should be tied to "validate", not "verify" #25

Closed
nguillaumin opened this issue May 27, 2018 · 2 comments
Closed

Plugin should be tied to "validate", not "verify" #25

nguillaumin opened this issue May 27, 2018 · 2 comments
Labels

Comments

@nguillaumin
Copy link

Hi,

I believe the "validate" phase of Maven would be more appropriate to tie the plugin to, rather than "verify". "verify" is to check the integrity of the generated artifact (i.e. JAR file) at the end of the build, whereas "validate" is to validate the project before the build starts.

Thanks!

@ppalaga
Copy link
Collaborator

ppalaga commented May 28, 2018

Hi @nguillaumin, using verify by default is a result of a thorough discussion at one of my former teams. My colleagues strongly prefered performing these checks after running the tests. The present default is thus intentional and I do not incline to change it at this time.

If you do not like the default, you can change the phase easily in the pom.xml of our project.

@ppalaga ppalaga closed this as completed May 28, 2018
@nguillaumin
Copy link
Author

Ok, fair enough. What tripped me up is that I usually use package as my default goal, so verify is never called until I call it explicitly...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants