Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #915, adds template construct #946

Merged
merged 20 commits into from Jul 13, 2022
Merged

Fixes #915, adds template construct #946

merged 20 commits into from Jul 13, 2022

Conversation

mweichert
Copy link
Collaborator

@mweichert mweichert commented Jul 5, 2022 •
edited

Finished:

  • Plugin authors can define templates
  • Templates are exposed via the create task.
  • Add support for running template handler, either via proxy or shell
  • Add integration tests using mock plugin

Todo:

  • Fix failing test in e2e/taqueria-plugin-jest.spec.ts

Deferred:

  • Tests failing: e2e/taqueria-plugin-contract-types.spec.ts
  • Tests failing: e2e/taqueria-plugin-flextesa.spec.ts

@cloudflare-pages
Copy link

cloudflare-pages bot commented Jul 5, 2022 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: acd31e3
Status: ✅  Deploy successful!
Preview URL: https://741dd234.taqueria.pages.dev
Branch Preview URL: https://915-templates.taqueria.pages.dev

View logs

@mweichert
Not finished. Added ability to run template handlers, but SDK still n…
3f6d863 
…eeds refactoring
@mweichert
Can now build sdk and CLI binary
16e67d9
@mweichert
Fixed ejs template handler
77b2b35
@mweichert
Fixed bug determining whether a template is composite
99be152
@mweichert
Added required field to PositionalArg type
c8f01cf
@mweichert
Implemented handler in CLI for templates
b118f81
@mweichert
Ensure plugin schema doesn't include function handlers for tasks or t…
4487ccf 
…emplates
@mweichert
Adjusted integration tests so that we can use node packages which are…
789dc3c 
… written using ESM modules. Added tests to verify that templates with handlers using EJS templates work correctly
@mweichert
Added tests for templates with handler set to function
33386ad
@mweichert
Ensure that all packages build correctly
3521e08
@mweichert
Fixed failing tests in e2e/taqueria-cli-commands.spec.ts
cfbda4e
@mweichert mweichert marked this pull request as ready for review July 9, 2022 21:33
@mweichert mweichert requested a review from a team July 9, 2022 21:33
@mweichert mweichert mentioned this pull request Jul 11, 2022
Closed
4 tasks
jchenche
jchenche approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@jchenche jchenche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 2 comments but other than that, everything looks good!

cli.ts Show resolved Hide resolved
taqueria-protocol/EphemeralState.ts Show resolved Hide resolved
@mweichert mweichert linked an issue Jul 12, 2022 that may be closed by this pull request
As a taq end-dev, I would like to instantiate a LIGO contract from a template, and have that contract automatically registered #907
Closed
4 tasks
@github-actions
Copy link
Contributor

Latest Commit c20f000
Taq Binaries

Linux
MacOS
Windows

npm Packages

npm install @taqueria/node-sdk@0.0.0-pr-946-c20f0005
taq install @taqueria/plugin-ligo@0.0.0-pr-946-c20f0005
taq install @taqueria/plugin-smartpy@0.0.0-pr-946-c20f0005
taq install @taqueria/plugin-taquito@0.0.0-pr-946-c20f0005
taq install @taqueria/plugin-flextesa@0.0.0-pr-946-c20f0005
taq install @taqueria/plugin-contract-types@0.0.0-pr-946-c20f0005
taq install @taqueria/plugin-archetype@0.0.0-pr-946-c20f0005 taq install @taqueria/plugin-tezos-client@0.0.0-pr-946-c20f0005 taq install @taqueria/state@0.0.0-pr-946-c20f0005

VSCode Extension VSIX Build skipped

@mweichert mweichert merged commit e37ae1c into main Jul 13, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 13, 2022
@hu3man hu3man deleted the 915-templates branch August 5, 2022 18:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jchenche jchenche jchenche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mweichert @jchenche