Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable all commands when config cannot be loaded #955

Merged
merged 8 commits into from Jul 8, 2022
Merged

Enable all commands when config cannot be loaded #955

merged 8 commits into from Jul 8, 2022

Conversation

ac10n
Copy link
Contributor

@ac10n ac10n commented Jul 7, 2022

No description provided.

@ac10n ac10n requested a review from a team July 7, 2022 20:41
@cloudflare-pages
Copy link

cloudflare-pages bot commented Jul 7, 2022 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 227e9b1
Status: ✅  Deploy successful!
Preview URL: https://e1389357.taqueria.pages.dev
Branch Preview URL: https://enable-all-commands-when-con.taqueria.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022 •
edited

Latest Commit 2ee9922
Taq Binaries

Linux
MacOS
Windows

npm Packages

npm install @taqueria/node-sdk@0.0.0-pr-955-2ee9922d
taq install @taqueria/plugin-ligo@0.0.0-pr-955-2ee9922d
taq install @taqueria/plugin-smartpy@0.0.0-pr-955-2ee9922d
taq install @taqueria/plugin-taquito@0.0.0-pr-955-2ee9922d
taq install @taqueria/plugin-flextesa@0.0.0-pr-955-2ee9922d
taq install @taqueria/plugin-contract-types@0.0.0-pr-955-2ee9922d
taq install @taqueria/plugin-archetype@0.0.0-pr-955-2ee9922d taq install @taqueria/plugin-tezos-client@0.0.0-pr-955-2ee9922d taq install @taqueria/state@0.0.0-pr-955-2ee9922d

VSCode Extension VSIX

taqueria-vscode-enable-all-commands-when-config-cannot-be-loaded-Linux

@ac10n ac10n marked this pull request as draft July 8, 2022 16:00
@ac10n ac10n requested a review from hu3man July 8, 2022 18:56
@ac10n ac10n force-pushed the enable-all-commands-when-config-cannot-be-loaded branch from 7282afe to a3ff7b9 Compare July 8, 2022 19:05
@ac10n ac10n marked this pull request as ready for review July 8, 2022 19:09
@ac10n ac10n requested a review from jchenche July 8, 2022 19:09
jchenche
jchenche approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@jchenche jchenche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

hu3man
hu3man approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@hu3man hu3man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @AlirezaHaghshenas

Left a couple comments about the messaging

I still have reservations about this approach but agree it's probably the best path for now

taqueria-plugin-taquito/originate.ts Outdated Show resolved Hide resolved
taqueria-vscode-extension/src/lib/helpers.ts Outdated Show resolved Hide resolved
taqueria-plugin-taquito/originate.ts Outdated Show resolved Hide resolved
@ac10n ac10n merged commit bb4f749 into main Jul 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2022
@hu3man hu3man deleted the enable-all-commands-when-config-cannot-be-loaded branch August 5, 2022 18:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jchenche jchenche jchenche approved these changes

@hu3man hu3man hu3man approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ac10n @jchenche @hu3man @jevonearth